-
Notifications
You must be signed in to change notification settings - Fork 159
ACP-226: Apply Min Block Delay to Block Builder #1310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+239
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/coreth into ceyonur/wait-for-event-refactor
…/coreth into ceyonur/wait-for-event-refactor
alarso16
reviewed
Oct 2, 2025
f02e5c7
to
aa9a2cc
Compare
Co-authored-by: Michael Kaplan <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
…ava-labs/coreth into ceyonur/acp-226-min-block-delay-builder
alarso16
reviewed
Oct 6, 2025
…ava-labs/coreth into ceyonur/acp-226-min-block-delay-builder
StephenButtolph
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
michaelkaplan13
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment suggestion, but LGTM
Co-authored-by: Michael Kaplan <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
ACP-226 directly affects the block building time. This PR adds ACP-226 delays to block builder.
How this works
It adds 2 delay system to the block builder:
1- ACP-226 based remaining min delay after parent's time. This is in order to pass the verification (to be added).
2- A constant min retry delay
How this was tested
added UTs
Need to be documented?
no
Need to update RELEASES.md?
updated